Don't strip shebang in expr-ctxt include!(…)
#146377
Open
+60
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
T-lang
rustbot
added
S-waiting-on-author
fmease
changed the title
include!(…)sinclude!(…)
fmease
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
no-incl-shebang-expr
branch
from
c611f6f to
3685183
Compare
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
no-incl-shebang-expr
branch
from
3685183 to
77cd6d1
Compare
Urgau
removed
the
S-waiting-on-team
traviscross
added
the
I-lang-radar
fmease
force-pushed
the
no-incl-shebang-expr
branch
from
77cd6d1 to
e8ef799
Compare
fmease
changed the title
include!(…)include!(…)
fmease
added
needs-crater
fmease
force-pushed
the
no-incl-shebang-expr
branch
from
e8ef799 to
e477732
Compare
fmease
added
I-lang-nominated
rustbot
added
the
S-waiting-on-review
fmease
removed
the
S-waiting-on-review
craterbot
added
S-waiting-on-review
joshtriplett
removed
the
needs-crater
Contributor
|
We talked about this in the lang meeting today, and this does seem the best step. @rfcbot fcp merge lang |
Collaborator
|
Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
rust-rfcbot
added
proposed-final-comment-period
Contributor
|
@rfcbot reviewed |
rust-rfcbot
added
final-comment-period
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
traviscross
removed
I-lang-nominated
This was referenced Dec 12, 2025
rust-rfcbot
added
finished-final-comment-period
Collaborator
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
Urgau
approved these changes
Dec 20, 2025
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 21, 2025
Don't strip shebang in expr-ctxt `include!(…)` No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
bors
added a commit
that referenced
this pull request
Dec 21, 2025
Rollup of 13 pull requests Successful merges: - #146377 (Don't strip shebang in expr-ctxt `include!(…)`) - #149437 (Fix trailing newline in JUnit formatter) - #149658 (tests/assembly-llvm/some-non-zero-from-atomic-optimization.rs: New test) - #149812 (Add const default for OnceCell and OnceLock) - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds) - #150009 (Enable llvm-libunwind by default for Hexagon targets) - #150035 (fix docustring on fetch_or) - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) - #150208 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 21, 2025
Don't strip shebang in expr-ctxt `include!(…)` No longer strip shebang interpreter directives in files that were `include`d in expression (statement) contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer strip shebang interpreter directives in files that were
included in expression (statement) contexts.